Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[peripheral] bye, bye libKODI_peripheral.cpp #11154

Merged
merged 2 commits into from
Dec 13, 2016

Conversation

AlwinEsch
Copy link
Member

Remove the use of shared add-on library for peripheral add-ons.

Description

The lib is no more used on add-on. It can be added without changes on add-ons, they need only a recompile.

Motivation and Context

Cleanup binary add-ons

How Has This Been Tested?

Has tested it with peripheral.joystick.

Screenshots (if appropriate):

bildschirmfoto vom 2016-12-13 00-47-35

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the Code guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have added tests to cover my change
  • All new and existing tests passed

@AlwinEsch AlwinEsch changed the title Remove shared addon lib peripheral [peripheral] bye, bye libKODI_peripheral.cpp Dec 12, 2016
@AlwinEsch AlwinEsch added Component: Binary add-ons Type: Cleanup non-breaking change which removes non-working or unmaintained functionality v18 Leia labels Dec 12, 2016
@AlwinEsch AlwinEsch added this to the L 18.0-alpha1 milestone Dec 12, 2016
@AlwinEsch
Copy link
Member Author

jenkins build this with addons please

@AlwinEsch AlwinEsch force-pushed the remove-shared-addon-lib-peripheral branch from 88271f2 to 87a51d9 Compare December 13, 2016 05:14
@AlwinEsch
Copy link
Member Author

jenkins build this with addons please again

@AlwinEsch AlwinEsch merged commit 3115b54 into xbmc:master Dec 13, 2016
@AlwinEsch AlwinEsch deleted the remove-shared-addon-lib-peripheral branch December 13, 2016 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Binary add-ons Type: Cleanup non-breaking change which removes non-working or unmaintained functionality v18 Leia
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant