Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[addon] bye, bye libXBMC_codec.cpp #11164

Merged
merged 1 commit into from
Dec 13, 2016

Conversation

AlwinEsch
Copy link
Member

Remove the use of shared add-on library used on pvr add-ons.

Description

The lib is no more used on add-on. It can be added without changes on add-ons, they need only a recompile.

Motivation and Context

Cleanup binary add-ons

How Has This Been Tested?

Has tested it with pvr.vdr.vnsi

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the Code guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have added tests to cover my change
  • All new and existing tests passed

@AlwinEsch AlwinEsch added Component: Binary add-ons Type: Cleanup non-breaking change which removes non-working or unmaintained functionality Component: PVR v18 Leia labels Dec 13, 2016
@AlwinEsch AlwinEsch added this to the L 18.0-alpha1 milestone Dec 13, 2016
@AlwinEsch
Copy link
Member Author

jenkins build this with addons please again

@FernetMenta
Copy link
Contributor

IMO we should let this entire thing die. It never evolved to what @opdenkamp had in mind and in its current state it does not bring any benefit.

@AlwinEsch
Copy link
Member Author

Comes removed very soon :).

First I move the functions on next changes to pvr (only used there) and after the multiple Instances way works, becomes it complete with his PVR stream parts removed.

@AlwinEsch AlwinEsch merged commit 8fc672f into xbmc:master Dec 13, 2016
@AlwinEsch AlwinEsch deleted the remove-shared-addon-lib-codec branch December 13, 2016 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Binary add-ons Component: PVR Type: Cleanup non-breaking change which removes non-working or unmaintained functionality v18 Leia
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants