Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code improvements for contextmenu eject items dvd/hdd #11168

Merged
merged 1 commit into from Dec 14, 2016
Merged

Code improvements for contextmenu eject items dvd/hdd #11168

merged 1 commit into from Dec 14, 2016

Conversation

razzeee
Copy link
Member

@razzeee razzeee commented Dec 13, 2016

Description

Just some improvements

Motivation and Context

Please lord @ksooo 馃檹

How Has This Been Tested?

Not tested yet, will be tested via jenkins builds.

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the Code guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have added tests to cover my change
  • All new and existing tests passed

ksooo
ksooo approved these changes Dec 13, 2016
View reviewed changes
Copy link
Member

@ksooo ksooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done. :-)

@ksooo
Copy link
Member

ksooo commented Dec 13, 2016

jenkins build and merge

@ksooo
Copy link
Member

ksooo commented Dec 14, 2016

Jenkins build and merge

@jenkins4kodi jenkins4kodi merged commit 5e44279 into xbmc:master Dec 14, 2016
@hudokkow hudokkow added this to the L 18.0-alpha1 milestone Dec 14, 2016
@razzeee razzeee deleted the followup-contextmenu-eject branch December 14, 2016 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksooo ksooo ksooo approved these changes

Assignees
No one assigned
Labels
v18 Leia
Projects
None yet
Milestone
Leia 18.0-alpha1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@razzeee @ksooo @hudokkow @jenkins4kodi