Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc cmake fixes #11183

Merged
merged 4 commits into from Dec 15, 2016
Merged

misc cmake fixes #11183

merged 4 commits into from Dec 15, 2016

Conversation

stefansaraev
Copy link
Contributor

@stefansaraev stefansaraev commented Dec 15, 2016 •
edited

Description

as title says.

Motivation and Context

I needed this to compile kodi for my OE fork

How Has This Been Tested?

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the Code guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have added tests to cover my change
  • All new and existing tests passed

@stefansaraev
[cmake] FindPython: fix typo
c81886e
@stefansaraev
[cmake] FindPython: append static libraries if any
1fd3340 
if we link against static libpython2.7.a, we need to add static
library dependencies to PYTHON_LIBRARIES
@stefansaraev
[cmake] FindMicroHttpd: do not assume gcrypt / gpg-error
e5925d1 
... use mhd static library dependencies instead if not
using unified depends
@hudokkow hudokkow added CMake Type: Fix non-breaking change which fixes an issue v18 Leia Backport: Needed labels Dec 15, 2016
@hudokkow
Copy link
Member

lgtm. @fetzerch?
jenkins build this please

@stefansaraev
Copy link
Contributor Author

android build errors seems related to recent PRs by @AlwinEsch - no shared libs installed anymore in lib/kodi/addons ?

@hudokkow
Copy link
Member

jenkins build this please

@stefansaraev stefansaraev mentioned this pull request Dec 15, 2016
Closed
9 tasks
@fetzerch
Copy link
Member

looks good to me as well, thanks

@MartijnKaijser MartijnKaijser added this to the L 18.0-alpha1 milestone Dec 15, 2016
@MartijnKaijser MartijnKaijser merged commit 630e4a3 into xbmc:master Dec 15, 2016
@stefansaraev stefansaraev deleted the cmake-fixes branch December 15, 2016 18:53
@MartijnKaijser MartijnKaijser mentioned this pull request Dec 22, 2016
Merged
@hudokkow hudokkow mentioned this pull request Dec 26, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Backport: Done CMake Type: Fix non-breaking change which fixes an issue v18 Leia
Projects
None yet
Milestone
Leia 18.0-alpha1
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@stefansaraev @hudokkow @fetzerch @AlwinEsch @MartijnKaijser