Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gui] fix crash when using container.property() in non-mediawindows #11254

Merged
merged 2 commits into from Dec 24, 2016

Conversation

@phil65
Copy link
Member

commented Dec 23, 2016

Quite an old bug: Kodi completely crashes when using container(xx).property(yy) in non-mediawindows (root cause: non-mediawindow is casted to CGUIMediaWindow)

Example crash trigger: phil65/skin.estuary@e259a49

Atm container.property() can only work for media windows because our CGUIBaseContainer class only carries a vector of listitems, and not a CFileItemList object.

EDIT: appended a second commit for container(xx).content crash, same reason as above.

@phil65 phil65 force-pushed the phil65:fix_container_property_crash branch from 2c2a6f8 to 1424569 Dec 23, 2016
@BigNoid

This comment has been minimized.

Copy link
Member

commented Dec 23, 2016

I don't think there's Container(xx).Property(yy) functionality? In that example commit you replace Container.ListItem.Property with Container.Property. I thought the recent additions allowed you to omit the container part, not the listitem part.

EDIT:
I see there's Container.Property(addoncategory) and Container.Property(reponame)
Nvm than, it was just that the crash commit looks wrong, but that's just for testing.

@phil65

This comment has been minimized.

Copy link
Member Author

commented Dec 23, 2016

Yeah that example is just there to have a test case, it doesn't make any sense in terms of functionality.

@phil65

This comment has been minimized.

Copy link
Member Author

commented Dec 24, 2016

jenkins build this please.

@phil65 phil65 merged commit 7b9b512 into xbmc:master Dec 24, 2016
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
jenkins4kodi I've found some spare time so building this now
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@phil65 phil65 deleted the phil65:fix_container_property_crash branch Dec 24, 2016
@MartijnKaijser MartijnKaijser modified the milestone: L 18.0-alpha1 Dec 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.