[win32][depends]Patch TagLib to v1.11.1 + d2e0e55 to fix regression causing hangs #11522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaveTBlake
added
Component: Depends
Type: Fix
|
Thanks @Paxxi for guiding me through this. |
9 tasks
9 tasks
…t radio (Shoutcasts)
DaveTBlake
force-pushed
the
taglib1_11_1
branch
from
3814b28
to
49e4266
Compare
DaveTBlake
changed the title
|
Caught master up with Krypton changes, thanks @Paxxi and @Rechi. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For win32 update TagLib to v1.11.1 with taglib/taglib@d2e0e55 as a patch to fix regression causing hangs with (Shoutcast) internet radio streams. See ticket http://trac.kodi.tv/ticket/17210 .
(Shoutcast) internet radio streams ending ".mp3" get passed to TabLib as if they have ID3 tags, and TabLib was spending upto 10 mins looking for them, looking for the end of the file incase the tags were there.
The step to v1.11.1 brings win32 in line with the package changes for other platforms made by #11101
and the patch to match #11543
This change has already been backported to v17 by #11547
Note for future update to TagLib - it is worth testing with Shoutcasts, as well as other music file formats.