[PVR] Trac 17246: Fix deadlock that might occur during initial channel icon search. #11536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksooo
added
Type: Fix
|
Oh that looks like an awesome visual Studio feature, must try it out. Fix looks sane to me |
|
jenkins build this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This user reported deadlock might occur on kodi startup when switching to the channels window while user supplied channel icons are still read and set.
Fixes trac 17246: http://trac.kodi.tv/ticket/17246
Stack traces (supplied by bug reporter):
Ghist of the fix is to put the problematic long running and guilib-calling (g_graphicsContext locking) channel icon search and set code into a CJob implementation.
Fix has been tested on latest master on macOS by me and using test build on Windows by the bug reporter.
@Jalle19 for review?