Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VideoPlayer: fix audio stream not started #11559

Merged
merged 1 commit into from
Jan 28, 2017
Merged

Conversation

FernetMenta
Copy link
Contributor

fixes in particular some DVD menus where an audio stream gets started while video is already running

@FernetMenta
Copy link
Contributor Author

jenkins build this please

@FernetMenta FernetMenta merged commit 6d5a87b into xbmc:master Jan 28, 2017
@FernetMenta FernetMenta deleted the sync branch January 28, 2017 17:43
@MartijnKaijser MartijnKaijser modified the milestone: L 18.0-alpha1 Feb 4, 2017
@b-pass
Copy link
Contributor

b-pass commented Feb 9, 2017

This seems to have broken Edl commercial skipping for me in Krypton HEAD. When it goes to do an Edl skip (VideoPlayer.cpp Line ~2421) video and audio both hang. Doing a manual seek forward or backward allows playback to continue.

I confirmed it was this commit since this is a one line change, commenting it out fixes the problem for me.

I tried two different videos and several different Edl commercials in each one and they all had this problem, I don't think it is specific to my recordings or my EDLs.

@FernetMenta
Copy link
Contributor Author

I see the issue which is a design flaw of EDL skipping. Instead of looking the the actual playing time it looks at the other end of the demuxer queue. As a result a cumbersome delayed flushing process was implemented that blocks the player thread for up to 8 seconds.
I rarely touched edl so far but now its time to do some rework.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport: Done Component: Video Type: Fix non-breaking change which fixes an issue v18 Leia
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants