[PAPlayer] Fix locking issues #1160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….cpp require data. Much better performance now - no more hammering stream locks. Also fixes bad sleep logic where it slept less when buffer was more full lol
|
i have amended the commit with a change of a cstdstring to a char[21] to avoid potential threading issues. |
|
yeah that was exactly what i've ment :) ... hopefully i'll get some time to pull some other fixes out of 1074 |
|
Looks good. |
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Much better performance now - no more hammering stream locks. Also fixes bad sleep logic where it slept less when buffer was more full lol
extracted from https://github.com/xbmc/xbmc/pull/1074