[PVR][guiinfo][Estuary] Recordings window: Introduce a content view filter #11704
Conversation
ksooo
added
Type: Feature
| #. Label for filtered recordings view value: 'show only watched' | ||
| #: xbmc/pvr/windows/GUIWindowPVRRecordings.cpp | ||
| msgctxt "#19299" | ||
| msgid "Watched" |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
ksooo
force-pushed
the
pvr-recordings-viewfilter
branch
2 times, most recently
from
e3ac55a
to
e4c1960
Compare
…ilter (all|watched|unwatched), like already existing for videos.
ksooo
force-pushed
the
pvr-recordings-viewfilter
branch
from
e4c1960
to
2a4c3d3
Compare
ksooo
changed the title
|
@ronie headsup: new infolabel: Container.NonFolderItems => https://github.com/xbmc/xbmc/pull/11704/files#diff-127e5f2786eb19ac8e0e2f04b3bf8306R2345 |
|
thx for the headsup! |
| { | ||
| unsigned int numItems = GetNumItems(); | ||
| if (info == CONTAINER_NUM_ITEMS && numItems && m_items[0]->IsFileItem() && (std::static_pointer_cast<CFileItem>(m_items[0]))->IsParentFolder()) | ||
| label = StringUtils::Format("%u", numItems-1); | ||
| else if (info == CONTAINER_NONFOLDER_ITEMS) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| @@ -2400,6 +2407,7 @@ const infomap container_bools[] ={{ "onnext", CONTAINER_MOVE_NEXT }, | |||
| { "numpages", CONTAINER_NUM_PAGES }, | |||
| { "numitems", CONTAINER_NUM_ITEMS }, | |||
| { "actualitems", CONTAINER_ACTUAL_ITEMS }, | |||
| { "nonfolderitems", CONTAINER_NONFOLDER_ITEMS }, | |||
| { "currentpage", CONTAINER_CURRENT_PAGE }, | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
A bit late but you are too fast in merging new stuff. |
|
Next time it would be good to separate gui related changes from skin changes. It will make things a bit easier to spot. |
|
I'm not too fast. If I'm not allowed to work with that speed I will stop working at all. The current speed is what keeps me happy with the project. ;-) And honestly, what you are saying is not wrong, but as I always use the subject line to tag what is effected and I always use the respective tags I do not see a real benefit in splitting a few lines PR in separate commits - this is, well, bureaucracy. |
|
Any intention to address my comments? If not I'll do it on my own. |
Sorry, I simply overlooked your comments. Please beautify the logic in GUIBaseContainer if you feel like this, but imo it is not okay to change the name of the GUI label, because "numfileitems" does not describe precisely the semantics of the new label. |
|
I'm currently working on it.
Agree, but I'll add the |
Recordings window: Introduce a content view filter (all|watched|unwatched), like already existing for videos and tv shows.
This was runtime tested on latest kodi master on macOS.
@Jalle19 for review, please?