[Fix]Skip trying to use TagLib to read tags from Shoutcasts #11771
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop trying to get TabLib to read metadata from Shoutcasts, but not excluding other internet streams.
An alternative to #11759
TabLib is not designed to cope with Shoutcasts, which while being an MPEG audio stream have a bespoke header and metadata format, and some streams cause TabLib to hang (or actually search indefinitely).
@fritsch @arnova @phate89 @wsnipex
I realise that a future refactoring wants to make TagLibVFSStream more controlled, and protect from unlimited reading. This is not an attempt at that, just a modest change that could be backported, that will avoid hangups caused by passing tagLib streams that we know do not contain tags it can read.