Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cleanup] silent some warnings #11817

Merged
merged 3 commits into from
Mar 11, 2017
Merged

[Cleanup] silent some warnings #11817

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b6e6d28
[cleanup] remove unused variables (leftover from 5567d03)
Rechi Mar 6, 2017
0b9b5b4
[cleanup] remove unused private fields (leftover from e6f1ca2)
Rechi Mar 6, 2017
ba441d8
[fix] truncate of value (leftover from 70fa8bd)
Rechi Mar 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 0 additions & 2 deletions xbmc/interfaces/legacy/ListItem.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,7 +399,6 @@ namespace XBMCAddon
throw WrongTypeException("When using \"cast\" or \"castandrole\" you need to supply a list of tuples for the value in the dictionary");

videotag.m_cast.clear();
const std::vector<InfoLabelStringOrTuple>& listValue = alt.later();
for (const auto& castEntry: alt.later())
{
// castEntry can be a string meaning it's the actor or it can be a tuple meaning it's the
Expand All @@ -419,7 +418,6 @@ namespace XBMCAddon

videotag.m_artist.clear();

const std::vector<InfoLabelStringOrTuple>& listValue = alt.later();
for (const auto& castEntry: alt.later())
{
const String& actor = castEntry.which() == first ? castEntry.former() : castEntry.later().first();
Expand Down
2 changes: 0 additions & 2 deletions xbmc/utils/BitstreamWriter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,6 @@ CBitstreamWriter::CBitstreamWriter(uint8_t *buffer, unsigned int buffer_size, in
, bit_left(32)
, buf(buffer)
, buf_ptr(buf)
, buf_end(buf + buffer_size)
, size_in_bits(8 * buffer_size)
{
}

Expand Down
3 changes: 1 addition & 2 deletions xbmc/utils/BitstreamWriter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,7 @@ class CBitstreamWriter
int writer_le;
uint32_t bit_buf;
int bit_left;
uint8_t *buf, *buf_ptr, *buf_end;
int size_in_bits;
uint8_t *buf, *buf_ptr;
};

////////////////////////////////////////////////////////////////////////////////////////////
Expand Down
2 changes: 1 addition & 1 deletion xbmc/utils/StringUtils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -915,7 +915,7 @@ long StringUtils::TimeStringToSeconds(const std::string &timeString)
std::string StringUtils::SecondsToTimeString(long lSeconds, TIME_FORMAT format)
{
bool isNegative = lSeconds < 0;
lSeconds = abs(lSeconds);
lSeconds = std::abs(lSeconds);
int hh = lSeconds / 3600;
lSeconds = lSeconds % 3600;
int mm = lSeconds / 60;
Expand Down