[PVR] Guide window: Fix selection after channelgroup switching #11879
Conversation
ksooo
added
Type: Fix
ksooo
force-pushed
the
pvr-fix-epg-grid-channelgroup-switching
branch
4 times, most recently
from
9d3bece
to
a3a7dcb
Compare
|
Just discovered that this is not yet ready to merge as I'm now doing a little too aggressive caching. Needs some more love... Adding WIP badge for now. |
|
Ping me again when you want a new review. |
|
same here, let me know if you're happy with it. |
ksooo
force-pushed
the
pvr-fix-epg-grid-channelgroup-switching
branch
6 times, most recently
from
30764f5
to
5fe7ca3
Compare
|
@MilhouseVH could you please include this PR into your next build, to get early feedback in case I broke stuff. |
|
Will do. |
xbmc/pvr/windows/GUIWindowPVRGuide.h
Outdated
| @@ -79,7 +80,7 @@ namespace PVR | |||
| void StartRefreshTimelineItemsThread(); | |||
| void StopRefreshTimelineItemsThread(); | |||
|
|
|||
| std::unique_ptr<CPVRRefreshTimelineItemsThread> m_refreshTimelineItemsThread; | |||
| std::shared_ptr<CPVRRefreshTimelineItemsThread> m_refreshTimelineItemsThread; | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| RefreshTimelineItems(); | ||
| // never call DoRefresh with locked mutex! | ||
| if (refreshTimelineItemsThread) | ||
| refreshTimelineItemsThread->DoRefresh(); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
ksooo
force-pushed
the
pvr-fix-epg-grid-channelgroup-switching
branch
from
5fe7ca3
to
8cc5697
Compare
|
@xhaggi the changes you requested are now in. |
|
Looks good thanks |
|
Thanks guys. I guess I will wait with the merge for some days to give milhouse build users the chance for some testing. |
|
In case we will do a 17.2 release, should we backport this? |
|
Sure, because it's a really annoying bug. |
ksooo
force-pushed
the
pvr-fix-epg-grid-channelgroup-switching
branch
from
8cc5697
to
4be46fa
Compare
|
rebased jenkins build this please |
|
+1 for backport if you're up for it |
…st if no changes came in while window was not active).
ksooo
force-pushed
the
pvr-fix-epg-grid-channelgroup-switching
branch
from
4be46fa
to
5feed5e
Compare
|
jenkins build this please |
This PR fixes wrong epg event selection after channel group switching in the PVR Guide window. Expected behavior is that the same event is still selected after a channel group switch, if the previously selected channel is also part of the new channel group. Otherwise, the first channel of the new group is selected.
The second commit introduces asynchrounous channel group switching. The gui render thread is no longer blocked while the epg grid gets refilled. A wait dialog is shown if the refill lasts longer than 100 msecs.
This was runtime tested on macOS and Linux on latest Kodi master.
@Jalle19 for code review?
@xhaggi for runtime testing (you reported the problems ;-)