Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

depends: remove libsdl_image and libsdl2 #11881

Merged
merged 5 commits into from
Mar 22, 2017
Merged

depends: remove libsdl_image and libsdl2 #11881

merged 5 commits into from
Mar 22, 2017

Conversation

stefansaraev
Copy link
Contributor

libsdl_image is an orphan dependency, not used for very long
libsdl2 seems unused

Description

Motivation and Context

How Has This Been Tested?

not tested at all.

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the Code guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have added tests to cover my change
  • All new and existing tests passed

@Rechi Rechi added Type: Cleanup non-breaking change which removes non-working or unmaintained functionality CMake Component: Depends v18 Leia labels Mar 20, 2017
@Rechi Rechi requested a review from wsnipex March 20, 2017 18:29
Rechi
Rechi reviewed Mar 20, 2017
View reviewed changes
xbmc/video/Teletext.cpp
#include <SDL/SDL_stdinc.h>
#elif HAVE_SDL_VERSION == 2
#include <SDL2/SDL_stdinc.h>
#else

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@Rechi
Copy link
Member

Rechi commented Mar 20, 2017

maybe Rechi@a795424 also isn't needed anymore

@stefansaraev
Copy link
Contributor Author

yep. added. thanks

@wsnipex
Copy link
Member

wsnipex commented Mar 20, 2017

looks good to me. I wonder if OSX will ever get rid of it.

@Rechi
Copy link
Member

Rechi commented Mar 20, 2017

jenkins build this please

@Rechi
Copy link
Member

Rechi commented Mar 22, 2017

jenkins build and merge

@Rechi Rechi added this to the L 18.0-alpha1 milestone Mar 22, 2017
@jenkins4kodi jenkins4kodi merged commit 537227d into xbmc:master Mar 22, 2017
@stefansaraev stefansaraev deleted the sdl-cleanup branch March 22, 2017 20:08
@MilhouseVH MilhouseVH mentioned this pull request Dec 9, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FernetMenta FernetMenta FernetMenta left review comments

@Rechi Rechi Rechi left review comments

@wsnipex wsnipex Awaiting requested review from wsnipex

Assignees
No one assigned
Labels
CMake Component: Depends Type: Cleanup non-breaking change which removes non-working or unmaintained functionality v18 Leia
Projects
None yet
Milestone
Leia 18.0-alpha1
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@stefansaraev @Rechi @wsnipex @FernetMenta @jenkins4kodi