Joysticks: Fix iMON conflicts by allowing users to enable/disable interfaces #11944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garbear
force-pushed
the
fix-imon
branch
3 times, most recently
from
be0c8bd
to
dd2ec9d
Compare
|
Middle commit has been expanded to fix empty defaults for other setting types |
|
jenkins build this please |
|
needs a rebase |
|
right, i was extremely close to merging this before disappearing for two weeks, then realized that it might be hard to fix any problems by smartphone. I'll get this rebased, tested and merged. |
|
jenkins build and merge |
|
@garbear you can merge this |
MartijnKaijser
added
Type: Improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes the fixes and improvements necessary for xbmc/peripheral.joystick#98.
The iMON failures result from scanning for DirectInput devices. With this fix, the user can selectively disable the DirectInput interface while keeping XInput controllers working.
Also, on linux, where we have three interfaces (Linux joystick api, udev and SDL 2) the user can select which interface to use. This will allow more testing for the udev switch.
A setting action has been added to allow the joystick add-on to be configured from within settings (instead of having to access joystick settings through the add-on manager).
Also included are three fixes for "select" controls in add-on settings.
Screenshots
Coming soon
Types of change