Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bluray][win32] Update libbluray #11954

Merged
merged 10 commits into from Jun 15, 2017
Merged

[bluray][win32] Update libbluray #11954

merged 10 commits into from Jun 15, 2017

Conversation

ace20022
Copy link
Member

No description provided.

@ace20022 ace20022 added Type: Feature non-breaking change which adds functionality v18 Leia Component: Video Platform: Windows WIP PR that is still being worked on labels Apr 11, 2017
@ace20022
Copy link
Member Author

jenkins build this please

@Rechi
Copy link
Member

Rechi commented Apr 15, 2017

@ace20022 please rebase

@Rechi
Copy link
Member

Rechi commented May 10, 2017

@ace20022 any updates?

@Rechi
Copy link
Member

Rechi commented May 11, 2017

just testing jenkins!
jenkins build this please

@ace20022
Copy link
Member Author

@Montellese @Paxxi Could you please check if e0d6076 is a good idea from the settings callback stuff point of view? It's a quick hack at the moment...

@Montellese
Copy link
Member

@ace20022 you could do the check in the OnSettingChanging() callback which gives you the possibility to reject changing a setting which would automatically result in the setting being disabled again if the JVM can't be loaded.

@ace20022
Copy link
Member Author

thanks for the quick response! There're also bd-hdmv menus which always work. I only want to inform the user that he has to check his java stuff.

@ace20022 ace20022 force-pushed the bd_leia_bdj branch 3 times, most recently from 6cb848e to 6659590 Compare June 2, 2017 07:35
@@ -1,3 +1,4 @@
system/*.dll .
system/libbluray*.jar .
project/Win32BuildSetup/dependencies/python27.dll .
project/BuildDependencies/${ARCH}/bin/*.dll .

This comment was marked as spam.


#include <string>

#include "discSettings.h"

This comment was marked as spam.

@ace20022
Copy link
Member Author

ace20022 commented Jun 2, 2017

jenkins build this please

@@ -1,3 +1,4 @@
system/*.dll .
project/BuildDependencies/${ARCH}/bin/libbluray*.jar .

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@Montellese
Copy link
Member

@ace20022 alright in that case OnSettingChanged() is the proper callback.

@ace20022 ace20022 force-pushed the bd_leia_bdj branch 2 times, most recently from 3cca579 to c16a659 Compare June 8, 2017 14:33
@ace20022 ace20022 force-pushed the bd_leia_bdj branch 2 times, most recently from d5a7641 to f0421ee Compare June 15, 2017 12:30
@ace20022 ace20022 added Type: Improvement non-breaking change which improves existing functionality and removed WIP PR that is still being worked on labels Jun 15, 2017
@ace20022 ace20022 added this to the L 18.0-alpha1 milestone Jun 15, 2017
@ace20022 ace20022 merged commit d7ea2b0 into xbmc:master Jun 15, 2017
@ace20022 ace20022 deleted the bd_leia_bdj branch June 15, 2017 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Video Platform: Windows Type: Feature non-breaking change which adds functionality Type: Improvement non-breaking change which improves existing functionality v18 Leia
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants