[Estuary][PVR] Guide window: Add possibility to switch between horizontal and vertical epg grid view. #11958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksooo
added
Type: Feature
ksooo
force-pushed
the
epg-grid-views
branch
3 times, most recently
from
6559873
to
1f311a1
Compare
phil65
reviewed
Apr 13, 2017
| <include>MediaMenuItemsCommon</include> | ||
| <label>$LOCALIZE[31023]</label> | ||
| <label2>[B]$INFO[Container.Viewmode][/B]</label2> | ||
| <visible>Integer.IsGreater(Container.ViewCount,1)</visible> |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
phil65
reviewed
Apr 13, 2017
| <control type="label" id="1"> | ||
| <left>68</left> | ||
| <top>-2</top> | ||
| <width>$PARAM[channel_label_width]</width> |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
2 comments, but looks good in general. |
…ntal and vertical epg grid view.
…s on kodi exit: 'Cleanup: Having to cleanup texture windows/pvr/epg_progress_horizontal.png'
…where appropriate, private vs. public, virtual vs. non-virtual, ...).
|
@phil65 your suggested changes are now in. Thanks for the review. |
|
jenkins build this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances Estuary's PVR Guide window with the feature to be able to choose between two epg grid views - 'vertical' (already present before this PR) and 'horizontal' (new).
The changes have been runtime tested on macOS, latest Kodi master.
@phil65 @ronie might be interested in taking a look at the skin changes.