Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[windows] drop FindFirstFileExW(...) workaround for Vista #11960

Merged
merged 1 commit into from Apr 13, 2017
Merged

[windows] drop FindFirstFileExW(...) workaround for Vista #11960

merged 1 commit into from Apr 13, 2017

Conversation

Rechi
Copy link
Member

@Rechi Rechi commented Apr 13, 2017

Description

FindFirstFileExW(...) required different parameters for Vista and newer versions.

Motivation and Context

At least Windows 7 is required by installer, so Vista workaround in code can also go.

How Has This Been Tested?

compiled

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the Code guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have added tests to cover my change
  • All new and existing tests passed

@Rechi Rechi added this to the L 18.0-alpha1 milestone Apr 13, 2017
@Rechi Rechi requested a review from Paxxi April 13, 2017 09:54
@MartijnKaijser
Copy link
Member

Jenkins build this please

@MartijnKaijser MartijnKaijser merged commit 21f4e3b into xbmc:master Apr 13, 2017
@Rechi Rechi deleted the winDropVista branch April 13, 2017 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Paxxi Paxxi Awaiting requested review from Paxxi

Assignees
No one assigned
Labels
Platform: Windows v18 Leia
Projects
None yet
Milestone
Leia 18.0-alpha1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Rechi @MartijnKaijser