Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spelling: [API] GetMininumGameAPIVersion #11993

Merged
merged 1 commit into from
May 11, 2017

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Apr 21, 2017

Spelling fixes

Description

Semi-automated spelling review of codebase (includes comments, code, public apis, documentation, etc)

Motivation and Context

I have a toolchain which I've been evolving for a while, and I like to test it on projects, especially as a way to give a little in appreciation of projects that I may be using/have used/plan to use.

How Has This Been Tested?

  • This has not been tested.

Types of change

  • Breaking change
    • Public APIs - I'm pretty sure I've renamed some public APIs. I'm happy to split such items out (either including backwards compat or dropping them entirely), but I'd rather have a conversation about which those things are before I eagerly split.

Checklist:

  • My code follows the Code guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have added tests to cover my change
  • All new and existing tests passed

@garbear
Copy link
Member

garbear commented Apr 21, 2017

Thanks, I appreciate the time these things can take. I've mode the corresponding game.libretro changes: kodi-game/game.libretro#12. Can you bump the Game API version to v1.0.30?

@garbear garbear mentioned this pull request Apr 21, 2017
23 tasks
@garbear
Copy link
Member

garbear commented Apr 21, 2017

Also needed is an update to game.moonlight. I'll take care of it this weekend unless you get to it first

@razzeee
Copy link
Member

razzeee commented May 7, 2017

@jsoref Would you be so kind and rebase this PR?

@AlwinEsch
Copy link
Member

AlwinEsch commented May 8, 2017

You must also update the version here if changed in versions.h: https://github.com/jsoref/xbmc/blob/8656c0a840e0d38a6818e98c19b0323a6a891828/addons/kodi.game/addon.xml#L2-L3

@jsoref
Copy link
Contributor Author

jsoref commented May 10, 2017

Done

@razzeee
Copy link
Member

razzeee commented May 10, 2017

jenkins build this please

@razzeee
Copy link
Member

razzeee commented May 11, 2017

jenkins build this please

@MartijnKaijser MartijnKaijser merged commit d4f64ba into xbmc:master May 11, 2017
@MartijnKaijser MartijnKaijser added this to the L 18.0-alpha1 milestone May 11, 2017
@jsoref jsoref deleted the spelling-game branch May 11, 2017 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants