[Android] Update AndroidKey.cpp #12000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extending support for the physical QWERTY keyboard in Android Kodi with processing of AKEYCODE_MOVE_HOME and AKEYCODE_MOVE_END key codes. Currently, these keyboard events are just ignored. In large Kodi list views jumping on FirstPage and LastPage is very convenient. I do not see any reason why it should not be supported in the Android Kodi , as it is on other OS platforms.
Rechi
added
Platform: Android
Type: Improvement
|
Thank you for your contribution and please excuse the late reply. |
|
+1 |
|
jenkins build this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extending support for the physical QWERTY keyboard in Android Kodi with processing of AKEYCODE_MOVE_HOME and AKEYCODE_MOVE_END key codes. Currently, these keyboard events are just ignored. In large Kodi list views jumping on FirstPage and LastPage is very convenient. I do not see any reason why it should not be supported in the Android Kodi, as it is on other OS platforms.
Description
Enabling support for HOME/END physical keyboard keys for moving in Kodi lists on Android.
Motivation and Context
There are more and more Android based media players on the market, not just tablets and phones. So, adding full support for the physical QWERTY keyboard in Android Kodi would be nice. Currently, I'm missing support and handling of the Home and End keyboard keys in the Android Kodi. Even my Android HTPC box handles Home/End keys properly, the Android Kodi does not process AKEYCODE_MOVE_HOME and AKEYCODE_MOVE_END key codes, so the keyboard events are just ignored. In large Kodi list views jumping on FirstPage and LastPage is very convenient and I used to use it on my previous Windows based HTPC. I do not see any reason why you should not support the keyboard in Kodi Android, as it is on other OS platforms.
http://forum.kodi.tv/showthread.php?tid=258808
http://forum.kodi.tv/showthread.php?tid=259037
How Has This Been Tested?
I did my own build with these changes included, using Kodi Jarvis as starting point. I'm using it daily for almost a year, without any issues.
Screenshots (if appropriate):
Types of change
Checklist: