[PVR] Search window improvements and fixes #12001
Conversation
ksooo
added
Type: Fix
xbmc/pvr/epg/EpgSearchFilter.cpp
Outdated
| @@ -114,7 +117,7 @@ bool CPVREpgSearchFilter::MatchDuration(const CPVREpgInfoTagPtr &tag) const | |||
|
|
|||
| bool CPVREpgSearchFilter::MatchStartAndEndTimes(const CPVREpgInfoTagPtr &tag) const | |||
| { | |||
| return (tag->StartAsLocalTime() >= m_startDateTime && tag->EndAsLocalTime() <= m_endDateTime); | |||
| return (tag->StartAsLocalTime() >= GetStartDateTime() && tag->EndAsLocalTime() <= GetEndDateTime()); | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
ksooo
changed the title
ksooo
force-pushed
the
pvr-epgsearch-improvements
branch
from
dd462ec
to
fcac632
Compare
|
@Jalle19 what do you think about this new approach? |
|
Answering my own question, I still do not like this fix. I think I will end up with something more pragmatic. CPVREpgSearchfilter::Reset will check the dates returned by the epg container and in case they are invalid it will init those values to "now" and "now + 10 days". This should solve all problems. |
ksooo
force-pushed
the
pvr-epgsearch-improvements
branch
from
fcac632
to
5e26512
Compare
|
@Jalle19 I guess now I have it. ;-) What's your opinion on this? |
|
Jenkins build this please |
Two changes related to the PVR search window :
Improvement: While searching epg events display standard "busy" dialog instaead of ugly modal dialog showing "searching..."
Fix: regression introduced with [PVR] Search window: Fix very first search after kodi start not working. #11992. "Find similar" (triggers epg search from other pvr windows) did not work anymore.
The changes have been runtime tested on macOS, latest kodi master
@Jallle19 for code review?