Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changed: always expand iso images in music window #12004

Merged
merged 1 commit into from
May 10, 2017
Merged

changed: always expand iso images in music window #12004

merged 1 commit into from
May 10, 2017

Conversation

notspiff
Copy link
Contributor

This makes iso images into filedirectories in the music window.

Currently, there has been no iso support for music (although we can do audio cd iso in the code i believe). Anyways, I want to add an add-on for SACD iso support. That requires this change.

It should do no harm, and by default .iso is not a music extension anyways.

@notspiff notspiff mentioned this pull request Apr 24, 2017
Merged
@herrnst herrnst mentioned this pull request May 1, 2017
Merged
razzeee
razzeee approved these changes May 6, 2017
View reviewed changes
Copy link
Member

@razzeee razzeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM :)

xbmc/filesystem/Directory.h Outdated
@@ -79,6 +79,6 @@ class CDirectory
/*! \brief Filter files that act like directories from the list, replacing them with their directory counterparts
\param items The item list to filter
\param mask The mask to apply when filtering files */

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@razzeee
Copy link
Member

razzeee commented May 10, 2017

jenkins build this please

@Rechi Rechi added Type: Feature non-breaking change which adds functionality Component: Music v18 Leia labels May 10, 2017
@Rechi Rechi added this to the L 18.0-alpha1 milestone May 10, 2017
@razzeee
Copy link
Member

razzeee commented May 10, 2017

jenkins build this please

@razzeee
Copy link
Member

razzeee commented May 10, 2017

Random build errors...

jenkins build this please

@MartijnKaijser MartijnKaijser merged commit a6198ff into xbmc:master May 10, 2017
@notspiff notspiff deleted the expand_iso branch May 11, 2017 08:55
@DaveTBlake
Copy link
Member

DaveTBlake commented Sep 9, 2018 •
edited
Loading

@notspiff just discovered this change introduces a regression which I need some help to fix.
Before this change adding <playlistasfolders>false</playlistasfolders> to advancedsettings.xml allowed .m3u playlists to be listed in the playlists node as if they were a file (total size shown) and enter caused playback. After this ,m3u files are always treated as folders, enter expanding the folder etc. and <playlistasfolders> ignored.

@DaveTBlake DaveTBlake mentioned this pull request Sep 10, 2018
Merged
@DaveTBlake DaveTBlake mentioned this pull request May 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@razzeee razzeee razzeee approved these changes

Assignees
No one assigned
Labels
Component: Music Type: Feature non-breaking change which adds functionality v18 Leia
Projects
None yet
Milestone
Leia 18.0-alpha1
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@notspiff @razzeee @DaveTBlake @MartijnKaijser @Rechi