Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed: always expand iso images in music window #12004

Merged
merged 1 commit into from May 10, 2017

Conversation

Projects
None yet
5 participants
@notspiff
Copy link
Contributor

commented Apr 24, 2017

This makes iso images into filedirectories in the music window.

Currently, there has been no iso support for music (although we can do audio cd iso in the code i believe). Anyways, I want to add an add-on for SACD iso support. That requires this change.

It should do no harm, and by default .iso is not a music extension anyways.

@Razzeee

Razzeee approved these changes May 6, 2017

Copy link
Member

left a comment

Thank you! LGTM :)

@@ -79,6 +79,6 @@ class CDirectory
/*! \brief Filter files that act like directories from the list, replacing them with their directory counterparts
\param items The item list to filter
\param mask The mask to apply when filtering files */

This comment has been minimized.

Copy link
@Razzeee

Razzeee May 6, 2017

Member

Could you please add the documentation for the new parameter here? It's now incomplete

This comment has been minimized.

Copy link
@notspiff

notspiff May 10, 2017

Author Contributor

done. in order to make it possible to write sane doxy, i have flipped the bool as well ;)

This comment has been minimized.

Copy link
@Razzeee

Razzeee May 10, 2017

Member

Much better the variable name was not that good before :)

@notspiff notspiff force-pushed the notspiff:expand_iso branch from 1edb674 to 1d1ff2e May 10, 2017

@notspiff notspiff force-pushed the notspiff:expand_iso branch from 1d1ff2e to e3f7b21 May 10, 2017

@Razzeee

This comment has been minimized.

Copy link
Member

commented May 10, 2017

jenkins build this please

@Rechi Rechi added this to the L 18.0-alpha1 milestone May 10, 2017

@Razzeee

This comment has been minimized.

Copy link
Member

commented May 10, 2017

jenkins build this please

@Razzeee

This comment has been minimized.

Copy link
Member

commented May 10, 2017

Random build errors...

jenkins build this please

@MartijnKaijser MartijnKaijser merged commit a6198ff into xbmc:master May 10, 2017

1 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
default Sorry, building this PR failed. Please check the logs for the errors.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@notspiff notspiff deleted the notspiff:expand_iso branch May 11, 2017

@DaveTBlake

This comment has been minimized.

Copy link
Member

commented Sep 9, 2018

@notspiff just discovered this change introduces a regression which I need some help to fix.
Before this change adding <playlistasfolders>false</playlistasfolders> to advancedsettings.xml allowed .m3u playlists to be listed in the playlists node as if they were a file (total size shown) and enter caused playback. After this ,m3u files are always treated as folders, enter expanding the folder etc. and <playlistasfolders> ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.