Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[settings] fix custom localization of setting labels/options #12063

Merged
merged 1 commit into from
May 10, 2017

Conversation

Montellese
Copy link
Member

Right now any settings dialog deriving from CGUIDialogSettingsBase can provide its own localization implementation for setting labels etc. This works great but I did not consider the labels used as part of the setting controls which currently all use g_localizeStrings instead of the settings dialog's specific localization implementation. This PR fixes it by passing an ILocalizer interface implementation to all the relevant parts of the settings GUI code.

Right now probably nobody will notice this because all strings are available through g_localizeStrings but it's inconsistent with the initial idea and it will fail when migrating add-on settings to core's settings system. Therefore there's no need for a backport to Krypton.

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the Code guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have added tests to cover my change
  • All new and existing tests passed

@Montellese Montellese added Type: Fix non-breaking change which fixes an issue Component: Settings v18 Leia labels May 5, 2017
@Montellese
Copy link
Member Author

jenkins build this please

@MartijnKaijser MartijnKaijser added this to the L 18.0-alpha1 milestone May 6, 2017
@Montellese
Copy link
Member Author

Any objections? jenkins was happy before he was struck down ;-)

@MartijnKaijser MartijnKaijser merged commit 2975dd5 into xbmc:master May 10, 2017
@Montellese Montellese deleted the fix_settings_localization branch May 11, 2017 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Settings Type: Fix non-breaking change which fixes an issue v18 Leia
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants