[settings] fix custom localization of setting labels/options #12063
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now any settings dialog deriving from
CGUIDialogSettingsBase
can provide its own localization implementation for setting labels etc. This works great but I did not consider the labels used as part of the setting controls which currently all useg_localizeStrings
instead of the settings dialog's specific localization implementation. This PR fixes it by passing anILocalizer
interface implementation to all the relevant parts of the settings GUI code.Right now probably nobody will notice this because all strings are available through
g_localizeStrings
but it's inconsistent with the initial idea and it will fail when migrating add-on settings to core's settings system. Therefore there's no need for a backport to Krypton.Types of change
Checklist: