[addons] Remove not needed parts #12109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From now becomes the version set direct by headers and is nearly independent from used addon type and version changes does not contact interface changes.
There become on creation of addon the needed Instance type given and checked against the version of addon. In future becomes this instance type also used to create the needed part on addon and use separate types together on one addon.
AlwinEsch
added
Component: Binary add-ons
Type: Cleanup
ksooo
approved these changes
May 16, 2017
|
jenkins build this please |
AlwinEsch
force-pushed
the
remove-not-needed-parts
branch
from
0502738
to
8b15568
Compare
This was referenced May 16, 2017
The version for the various addon types becomes now done by only one function.
AlwinEsch
force-pushed
the
remove-not-needed-parts
branch
from
8b15568
to
b23199b
Compare
|
jenkins build this please |
1 similar comment
|
jenkins build this please |
|
Ignore Windows fail |
|
Thanks @MartijnKaijser! |
|
I'm sorry to spam everyone but, yeah... it's in order. @AlwinEsch, 👏 👏 👏 🎩 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove no more needed parts since #12029
Description
This remove the old version check functions who was defined before on some types. This becomes now done by one fixed function for all addon types and no more needed to change on addon itself (is done automatic during compile)
Motivation and Context
Next step from kodi-agile
How Has This Been Tested?
Screenshots (if appropriate):
Types of change
Checklist: