[buildsteps][windows] keep downloaded vcredist #12175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
have run win32 on jenkins a second time and vcredist was kept |
|
Looks good to me but I'm wondering if we should just store it in downloads to keep down the list of places we store non-git stuff |
Paxxi
approved these changes
Jul 18, 2017
Rechi
added
the
On hold
Rechi
force-pushed
the
buildstepsWindows
branch
from
2191c73
to
5cb02b3
Compare
|
@Rechi can we merge this? |
Rechi
force-pushed
the
buildstepsWindows
branch
from
5cb02b3
to
7203839
Compare
Rechi
removed
the
On hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Don't remove the downloaded vcredist if calling
prepare-env.batMotivation and Context
Vcredist doesn't change and there is no need to re-download it for every jenkins run.
Types of change
Checklist: