Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeviceKit cleanup #12383

Merged
merged 2 commits into from Jul 7, 2017
Merged

DeviceKit cleanup #12383

merged 2 commits into from Jul 7, 2017

Conversation

yol
Copy link
Member

@yol yol commented Jun 28, 2017

DeviceKit-disks was renamed udisks in 2009, DeviceKit-power was renamed upower in 2010. Kodi has support for UDisks and UPower. RIP DeviceKit.

Description

Remove PM and storage implementations using DeviceKit.

Motivation and Context

Follow-up from #12371

How Has This Been Tested?

Run-tested on X11

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the Code guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have added tests to cover my change
  • All new and existing tests passed

@Rechi Rechi added Type: Cleanup non-breaking change which removes non-working or unmaintained functionality Platform: Linux v18 Leia labels Jun 28, 2017
@MartijnKaijser
Copy link
Member

jenkins build this please

@Rechi
Copy link
Member

Rechi commented Jun 28, 2017

There are two different ways to fix the raspberry pi build issue

  • remove storage/linux directory at cmake/treedata/rbpi/subdirs.txt
  • surround core_add_library(...) at xbmc/storage/linux/CMakeLists.txt with if(NOT ENABLE_STATIC_LIBS OR DBUS_FOUND OR UDEV_FOUND)

@yol
Copy link
Member Author

yol commented Jun 28, 2017

Just wondering, raspberry pi does not have udev?

@MartijnKaijser
Copy link
Member

@popcornmix?

@popcornmix
Copy link
Member

Pi does use udev (it is just standard linux).
I believe udev isn't enabled for jenkins builds purely due to limitations of the build system when cross compiling. @wsnipex may know more about this.

@wsnipex
Copy link
Member

wsnipex commented Jun 29, 2017

udev is provided by systemd these days and we don't have that (nor old standalone udev) in depends.
It only works on x86 because we "cheat" too much there and allow the use of system libs.

I'm a bit puzzled about dbus though. We have it in depends, but it is never built. I've tried to track down if that was removed in the past, but can't find a ref that it was actually ever built...

@Rechi
Copy link
Member

Rechi commented Jul 7, 2017

@pkerling this needs a rebase

DeviceKit disk API was superseded by UDisks in 2009. No system that can
run up-to-date Kodi should still use it.
DeviceKit power API was superseded by UPower in 2010. No system that can
run up-to-date Kodi should still use it.
@yol
Copy link
Member Author

yol commented Jul 7, 2017

Done. Can we merge this then? Pi build stuff is peculiar, but not really related to this PR.

@popcornmix
Copy link
Member

If nothing has changed (i.e. Jenkins builds for Pi successfully without udev enabled) then no objections here.

@MartijnKaijser MartijnKaijser added this to the L 18.0-alpha1 milestone Jul 7, 2017
@MartijnKaijser MartijnKaijser merged commit 734cda1 into xbmc:master Jul 7, 2017
@yol yol deleted the dbus-cleanup branch July 18, 2017 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform: Linux Type: Cleanup non-breaking change which removes non-working or unmaintained functionality v18 Leia
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants