Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[addons] replace OnEnable with event handlers for repository updater #12415

Merged
merged 1 commit into from
Jul 5, 2017

Conversation

tamland
Copy link
Member

@tamland tamland commented Jul 3, 2017

No description provided.

@tamland tamland added Component: Add-ons Type: Cleanup non-breaking change which removes non-working or unmaintained functionality labels Jul 3, 2017
@tamland
Copy link
Member Author

tamland commented Jul 4, 2017

jenkins build this please

@MartijnKaijser MartijnKaijser merged commit 7673f74 into xbmc:master Jul 5, 2017
@MartijnKaijser MartijnKaijser added this to the L 18.0-alpha1 milestone Jul 5, 2017
@Rechi Rechi added the v18 Leia label Jul 5, 2017
@Rechi
Copy link
Member

Rechi commented Jul 5, 2017

This causes a segmentation fault (on osx and linux) in the test suite.
I can look at it in greater detail later if needed.

@ksooo
Copy link
Member

ksooo commented Jul 5, 2017

Crashes on Kodi exit.

(lldb) thread backtrace
* thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x8)
  * frame #0: 0x00000001003d8928 kodi.bin`CServiceManager::GetAddonMgr() [inlined] std::__1::unique_ptr >::get(this=0x0000000000000008) const at memory:2715
    frame #1: 0x00000001003d8918 kodi.bin`CServiceManager::GetAddonMgr(this=0x0000000000000000) at ServiceManager.cpp:176
    frame #2: 0x00000001003d2f53 kodi.bin`CServiceBroker::GetAddonMgr() at ServiceBroker.cpp:28
    frame #3: 0x000000010058a828 kodi.bin`ADDON::CRepositoryUpdater::~CRepositoryUpdater(this=0x0000000104b31850) at RepositoryUpdater.cpp:62
    frame #4: 0x0000000100589b35 kodi.bin`ADDON::CRepositoryUpdater::~CRepositoryUpdater(this=0x0000000104b31850) at RepositoryUpdater.cpp:61
    frame #5: 0x00007fffc3cd0178 libsystem_c.dylib`__cxa_finalize_ranges + 332
    frame #6: 0x00007fffc3cd04b2 libsystem_c.dylib`exit + 55
    frame #7: 0x00007fffc3c3b23c libdyld.dylib`start + 8

Seems it is not a good idea to have a global CRepositoryUpdater instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Add-ons Type: Cleanup non-breaking change which removes non-working or unmaintained functionality v18 Leia
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants