[PVR][guiinfo][Estuary] PVR info dialog, recordings window: cleanup and extend #12416
Conversation
ksooo
added
Type: Cleanup
xbmc/GUIInfoManager.cpp
Outdated
| /// \anchor ListItem_ExpirationTime | ||
| /// _string_, | ||
| /// Expiration time of the selected item in a container, empty string if not supported | ||
| /// } |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
could you move the "genre" and "expires" info to a second column in the PVR info dialog? Currently there is so much lost space on the right handside of it. Alternatively, have you tried moving the plot to the right? These are just two quick ideas. I also just thought about moving the "meta data" below the thumbnail. But this dialog might in general need a bit more love from our skinners. @phil65 ? |
|
I agree, but due to lack of knowledge on my end I leave this to our skinners, in a follow-up PR. |
ksooo
force-pushed
the
pvr-estuary-cleanup-recordings-indo
branch
from
f5a858b
to
c6240f5
Compare
:-) The "Expires: foo" line is not present, then. |
|
@ksooo fair point. I hope one of our skinners will give this dialog some love. Btw, is the channel info below the recording title really important? I think the episode title ("Steg mit Aussicht") might be better suited there, and the channel name moved down to the meta data. Just an idea and no hard feelings. |
|
jenkins build this please |
…e/time for pvr recordings
ksooo
force-pushed
the
pvr-estuary-cleanup-recordings-indo
branch
from
c6240f5
to
29eb90a
Compare
…ow (consistency of data order, add expiration date/time)
ksooo
force-pushed
the
pvr-estuary-cleanup-recordings-indo
branch
from
29eb90a
to
1a95156
Compare
|
@da-anda better now?
|
|
yep, better IMO. But I would have done it like "Sender: Das Erste HD" to match the other meta data. Up to you if you want to adjust it that way. And thanks much for maintaining and improving PVR. |
|
I had it exactly like you suggested, but channel name imo is special and important; it needs to be highlighted from other less important properties. |
is it? That's probably subject of personal preferences and recording habits. I primarily care for the show I recorded and not on which channel it was on. But again, no hard feelings, fine with whatever you prefer. Btw, because it just came to my mind. Might be nice to also have a "delete" button in the OSD as well as "find similar" and maybe even "edit timer" (in case it's from a recurring timer rule, if we store that info somewhere). Just some ideas for the future, as the "play" button is kinda lost down there. |
|
@phil65 are the skin changes okay? |
|
yup, looks fine. |
|
jenkins build this please |
|
jenkins errors are unrelated |
guiinfo: Add LISTITEM_EXPIRATION_DATE and LISTITEM_EXPIRATION_TIME
Estuary: PVR info dialog & recordings window: Reorder some items and add expriration date/time for recordings:
PVR info dialog (before):
PVR info dialog (after):
Recordings window (before):
Recordings window (after):
This has been runtime tested on macOS, latest master.
@ronie, phil65 fyi