Fix seeking with PTS values exceeding max int #12442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rechi
added
Type: Fix
ksooo
requested changes
Jul 7, 2017
xbmc/cores/VideoPlayer/Edl.cpp
Outdated
| @@ -770,16 +770,16 @@ int CEdl::RemoveCutTime(int iSeek) const | |||
| return iSeek - iCutTime; | |||
| } | |||
|
|
|||
| int CEdl::RestoreCutTime(int iClock) const | |||
| double CEdl::RestoreCutTime(double iClock) const | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
rbuehlma
force-pushed
the
fix_seek_with_huge_pts
branch
from
b2d953c
to
d5aeb24
Compare
ksooo
requested changes
Jul 7, 2017
xbmc/cores/VideoPlayer/Edl.cpp
Outdated
| if (m_vecCuts[i].action == CUT && iSeek >= m_vecCuts[i].start) | ||
| iSeek += m_vecCuts[i].end - m_vecCuts[i].start; | ||
| if (m_vecCuts[i].action == CUT && dSeek >= m_vecCuts[i].start) | ||
| dSeek += (double)m_vecCuts[i].end - (double)m_vecCuts[i].start; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
rbuehlma
force-pushed
the
fix_seek_with_huge_pts
branch
from
d5aeb24
to
b67d0aa
Compare
FernetMenta
approved these changes
Jul 8, 2017
rbuehlma
force-pushed
the
fix_seek_with_huge_pts
branch
from
b67d0aa
to
ea16676
Compare
ksooo
approved these changes
Jul 8, 2017
|
jenkins build this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #12086
I found some additional places where double got pushed into an int.