Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[depends][win32] Hopefully fix a python crash #12502

Merged
merged 1 commit into from
Jul 14, 2017
Merged

[depends][win32] Hopefully fix a python crash #12502

merged 1 commit into from
Jul 14, 2017

Conversation

Paxxi
Copy link
Member

@Paxxi Paxxi commented Jul 14, 2017

We're crashing a lot because of a comparison that should be equals isn't even though memory looks good. possible race condition

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the Code guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have added tests to cover my change
  • All new and existing tests passed

@Paxxi
Hopefully fix a python crash
ac46fee 
We're crashing a lot because of a comparison that should be equals isn't even though memory looks good. possible race condition
@Paxxi Paxxi added this to the L 18.0-alpha1 milestone Jul 14, 2017
@Paxxi Paxxi requested a review from Rechi July 14, 2017 16:20
Rechi
Rechi approved these changes Jul 14, 2017
View reviewed changes
Copy link
Member

@Rechi Rechi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

packages look correct

@MartijnKaijser MartijnKaijser merged commit 89a42ed into xbmc:master Jul 14, 2017
Paxxi added a commit that referenced this pull request Jul 17, 2017
@Paxxi
Merge pull request #12512 from Paxxi/pyfix
f886c6c 
[xbmc][depends][win32] Fix python that broke in #12502
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rechi Rechi Rechi approved these changes

Assignees
No one assigned
Labels
Backport: Done Component: Depends Platform: Windows Type: Fix non-breaking change which fixes an issue v18 Leia
Projects
None yet
Milestone
Leia 18.0-alpha1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Paxxi @Rechi @MartijnKaijser