exit GIL when calling into GUI #12504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@marcelveldt confirmed that this fixes deadlock issues he was observing with spotify addon. |
FernetMenta
added
Backport: Needed
Type: Fix
|
@FernetMenta not sure backporting this one is easy as i had a lot of conflict when i tried. |
|
@MartijnKaijser conflics are because of LOCKGUIIF, right? Resovling this should be straightforward. @marcelveldt wanted to backport this, iirc |
|
@marcelveldt could you please make a PR soon so we can get 17.4 RC out the door? |
|
@MartijnKaijser seems to be pretty straightforward indeed, I'll submit the PR later today. |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GIL was never unlocked because the addon class clears tls