[addons] change binary callbacks #12596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamland
reviewed
Aug 3, 2017
| return nullptr; | ||
| } | ||
|
|
||
| return strdup(CServiceBroker::GetSettings().GetString(CSettings::SETTING_LOOKANDFEEL_SKIN).c_str()); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
AlwinEsch
force-pushed
the
add-callbacks
branch
2 times, most recently
from
d590594
to
c1b895b
Compare
|
jenkins build this please |
AlwinEsch
force-pushed
the
add-callbacks
branch
from
c1b895b
to
f2b6002
Compare
|
jenkins build this please |
This add a callback who also present on python and becomes needed on e.g. Web browser addon to know used skin name. The change is more general and included to a new request.
This change the id usage of strings on new binary addons to override a kodi string id with a own for him itself.
AlwinEsch
force-pushed
the
add-callbacks
branch
from
f2b6002
to
8889c7d
Compare
|
You know that I always get puzzled about this version number stuff, but imo this change breaks all old style binary add-ons, like pvr add-ons. @AlwinEsch @MilhouseVH not sure whether I'm actually right, be in case I am, you are informed... |
|
Okay, you did not modify the function tables, right? Thus, all should be fine, but I would be happy if you could confirm this. |
|
PVR still use the old and not affected by them. Also is with a add of callback function (if added to the end) still backward compatible. |
|
Sure, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This add a callback who also present on python and becomes needed
on e.g. Web browser addon to know used skin name.
The change is more general and included to a new request.
This change the id usage of strings on new binary addons to override
a kodi string id with a own for him itself.
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of change
Checklist: