-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DVD] fix: libdvd's stream API doesn't handle incomplete reads well #12622
Conversation
Thanks, I'll include this in tonight's test build and get some feedback. |
CLog::Log(LOGERROR,"read error dvd_inputstreamnavigator_cb_read"); | ||
return i_r; | ||
} | ||
if (i_r == 0) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
jenkins build this please |
@MilhouseVH - have you received any feedback yet? |
@Voyager1 none so far. Unfortunately the user hasn't been back on the forum since reporting it, however I've just sent him a PM. |
@Voyager1 Still no feedback I'm afraid - have followed it up with a forum email. I assume it now works, but if not then take your time to fix it... :) |
@MilhouseVH - thanks. At least in my tests I reproduced the issue and was able to confirm that the fix remediated it. |
as title
Description
streaming API in libdvd doesn't handle incomplete reads very well, as identified by a user who was trying to read DVD iso over an ftp connection.
Motivation and Context
How Has This Been Tested?
tested using an ISO via an ftp connection
Screenshots (if appropriate):
Types of change
Checklist: