Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DVD] fix: libdvd's stream API doesn't handle incomplete reads well #12622

Merged
merged 1 commit into from
Aug 5, 2017

Conversation

Voyager1
Copy link

@Voyager1 Voyager1 commented Aug 3, 2017

as title

Description

streaming API in libdvd doesn't handle incomplete reads very well, as identified by a user who was trying to read DVD iso over an ftp connection.

Motivation and Context

How Has This Been Tested?

tested using an ISO via an ftp connection

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the Code guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have added tests to cover my change
  • All new and existing tests passed

@MilhouseVH
Copy link
Contributor

Thanks, I'll include this in tonight's test build and get some feedback.

CLog::Log(LOGERROR,"read error dvd_inputstreamnavigator_cb_read");
return i_r;
}
if (i_r == 0)

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@Rechi Rechi added Type: Fix non-breaking change which fixes an issue v18 Leia Component: Video labels Aug 4, 2017
@Rechi Rechi added this to the L 18.0-alpha1 milestone Aug 4, 2017
@Voyager1
Copy link
Author

Voyager1 commented Aug 4, 2017

jenkins build this please

@MartijnKaijser MartijnKaijser merged commit c0952b6 into xbmc:master Aug 5, 2017
@Voyager1
Copy link
Author

Voyager1 commented Aug 6, 2017

@MilhouseVH - have you received any feedback yet?

@MilhouseVH
Copy link
Contributor

@Voyager1 none so far. Unfortunately the user hasn't been back on the forum since reporting it, however I've just sent him a PM.

@MilhouseVH
Copy link
Contributor

@Voyager1 Still no feedback I'm afraid - have followed it up with a forum email. I assume it now works, but if not then take your time to fix it... :)

@Voyager1
Copy link
Author

@MilhouseVH - thanks. At least in my tests I reproduced the issue and was able to confirm that the fix remediated it.

@Voyager1 Voyager1 deleted the fix-dvdread branch December 25, 2017 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Video Type: Fix non-breaking change which fixes an issue v18 Leia
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants