[cleanup] silence compiler warnings #12631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rechi
added
Type: Cleanup
garbear
reviewed
Aug 5, 2017
| @@ -251,7 +251,7 @@ bool CAndroidUtils::SetNativeResolution(const RESOLUTION_INFO &res) | |||
| CXBMCApp::SetDisplayMode(atoi(res.strId.c_str())); | |||
| s_res_cur_displayMode = res; | |||
| } | |||
| else if (abs(currentRefreshRate() - res.fRefreshRate) > 0.0001) | |||
| else if (std::abs(currentRefreshRate() - res.fRefreshRate) > 0.0001) | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
'const' type qualifier on basic type returns has no effect
|
any objections? |
FernetMenta
approved these changes
Aug 10, 2017
|
I'm fine with your changes too. Thank you for reducing the amount of warnings. |
AchimTuran
approved these changes
Aug 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Silence compiler warnings.
Motivation and Context
I don't like those warnings.
How Has This Been Tested?
compiled for android, osx and windows
Screenshots (if appropriate):
Types of change
Checklist: