keep extradata on stream-refresh if not given from demuxer #12656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FernetMenta
reviewed
Aug 11, 2017
| @@ -472,15 +456,6 @@ void CDVDDemuxClient::RequestStream(CDemuxStream *stream, std::map<int, std::sha | |||
| if (streamSubtitle->m_parser) | |||
| streamSubtitle->m_parser->flags |= PARSER_FLAG_COMPLETE_FRAMES; | |||
| } | |||
|
|
|||
| if (source->ExtraSize == 4) | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
FernetMenta
reviewed
Aug 11, 2017
| { | ||
| newStream->profile = oldStream->profile; | ||
| newStream->level = oldStream->level; | ||
| extraSource = oldStream.get(); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@FernetMenta I suppose this one can be closed now that your PR is in? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
extradata extracted from stream by DemuxClient must not be removed if demuxer is requested for possible changed stream infos without providing extradata.
This issue is a side effect of: PR12651
Motivation and Context
Live-TV with TVH does not provide video. Reason is that tvh demuxer does not provide codec extra-data.
How Has This Been Tested?
Win10 / 32 TVH german channels
Types of change