Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lang] remove language add-on migration code #12658

Merged
merged 1 commit into from
Aug 16, 2017

Conversation

tamland
Copy link
Member

@tamland tamland commented Aug 11, 2017

It's been 3 version since we migrated. No need for this anymore

@tamland tamland added the Type: Cleanup non-breaking change which removes non-working or unmaintained functionality label Aug 11, 2017
@enen92
Copy link
Member

enen92 commented Aug 11, 2017

Is this change for strings.xml or for the language folder layout (resources/language/English/strings.po)? or both?
Thanks

@MartijnKaijser
Copy link
Member

It's the handling of the transfer from when we had language files shipped with Kodi itself towards the Kodi language addons to find the matching one and download it.
This shouldn't affect strings for addons itself.

Copy link
Member

@Montellese Montellese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok.

language = CServiceBroker::GetSettings().GetString(CSettings::SETTING_LOCALE_LANGUAGE);

if (language.empty())

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@tamland tamland merged commit 488eecb into xbmc:master Aug 16, 2017
@tamland tamland deleted the drop_lang_migration branch August 16, 2017 11:06
@Rechi Rechi added the v18 Leia label Aug 16, 2017
@Rechi Rechi added this to the L 18.0-alpha1 milestone Aug 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Cleanup non-breaking change which removes non-working or unmaintained functionality v18 Leia
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants