Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Wayland windowing system #12664
Add native Wayland windowing implementation as result of GSoC 2017 project from https://github.com/pkerling/xbmc/
This has been in the works for the last three months.
I have squashed the commits so that modifications and additions to the non-Wayland Kodi code are separate commits and that the Wayland windowing implementation itself is one commit. That implementation of course also has a history and is made up of a large number of commits (available via the linked GitHub repository) that were reviewed in feature chunks by @FernetMenta, but it would probably not be useful to keep it in mainline.
I realize that this is quite a lot of code to merge so I'm open to any suggestions that make it easier to handle.
Building with Wayland is fully integrated into the depends system and can be achieved by calling
Motivation and Context
Linux is transitioning to the Wayland protocol instead of X11 for the long term. To offer a competitive user experience on Linux and get all the shiny new features, Kodi must support Wayland natively instead of running via Xwayland X11 emulation.
How Has This Been Tested?
Build and run test on linux64 with GL and GLES
Screenshots (if appropriate):
It really looks just like on X :-)
Types of change
Nice :-) I followed every issue and every issue review - really nice work. From my pov can go in every time if it does not break anything. Perhaps - only a suggestion - it would be good to add "Wayland:" to the commits actually doing wayland features. This is especially useful when going just through a git log without seeing directly which file it changes.
But it's on your mentor to decide on this minor - only a suggestion.