Fix: check if we have to show simple menu only after we checked if we have a resume point #12674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
system/lcms2.dll should not be part of this pr :) |
phate89
force-pushed
the
fix_bd_simplemenu
branch
from
71ff908
to
7b1105e
Compare
|
mm it keeps popping up everytime not sure why.. Fixed it :) |
ace20022
requested changes
Aug 15, 2017
xbmc/Application.cpp
Outdated
| //check if we must show the simplified bd menu | ||
| if (!CGUIDialogSimpleMenu::ShowPlaySelection(const_cast<CFileItem&>(item))) | ||
| return PLAYBACK_CANCELED; | ||
| } |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
phate89
force-pushed
the
fix_bd_simplemenu
branch
from
4bbf58b
to
8203fa7
Compare
… have a resume point
phate89
force-pushed
the
fix_bd_simplemenu
branch
from
8203fa7
to
fafb49f
Compare
ace20022
approved these changes
Aug 15, 2017
|
Looks, good. Thanks for the pr! |
|
Do you think it's worth it to backport to krypton? |
|
I don't have time to test it, but I trust you that it works in all cases. Therefore +1 for a backport. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Right now we skip bd simplemenu everytime we ask for a resume doesn't matter if there is. This pr changes that. It will skip simplemenu only if there's really a resumepoint set.
Motivation and Context
Right now when we start "playdisc" builtin we ask to resume and there's a check in bd simplemenu that skips the menu if there's a resume request.
This means if you add a bd and start it with playdisc (from estuary main page for example) you won't ever get the bd simplemenu even if you set it and it will start to play directly the bluray. It's a problem that already exists in krypton but in leia it will even be worse because instead of loading the default playlist it will try to load the bd menu with different results (not all bd menus works great)
How Has This Been Tested?
I tested with a couple of bluray and with resume points
Types of change
Checklist: