[utils] fix component log functions introduced at 06bbead #12685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Montellese
reviewed
Aug 17, 2017
xbmc/utils/log.cpp
Outdated
| va_list va; | ||
| va_start(va, format); | ||
| CLog::LogFunction(loglevel, functionName, format, va); | ||
| LogString(loglevel, fNameStr + StringUtils::FormatV(format, va)); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
made this log accidentally LOGAUDIO component specific
Rechi
force-pushed
the
fixComponentLogging
branch
from
a86b080
to
139fe71
Compare
|
WIN-64 failure unrelated |
|
confirmed to fix the issue in latest Milhouse build, https://forum.kodi.tv/showthread.php?tid=298462&pid=2633603#pid2633603 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the component log functions of
CLogwhich I added at 06bbead (#12676).Motivation and Context
fix a crash
Types of change
Checklist: