[PVR] Fix jumping timeline while switching channel groups in Guide window #12707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksooo
added
Type: Fix
Jalle19
approved these changes
Aug 23, 2017
| { | ||
| // first block of previously selected tag is always the calculated block rounded up. | ||
| // refer to CGUIEPGGridContainerModel::Refresh, where the model is created, for details! | ||
| float fBlockIndex = (eventStart - gridStart).GetSecondsTotal() / 60.0f / CGUIEPGGridContainerModel::MINSPERBLOCK; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| // first block of tag before previously selected gap tag is always the calculated block rounded up. | ||
| // refer to CGUIEPGGridContainerModel::Refresh, where the model is created, for details! | ||
| float fBlockIndex = (eventStart - gridStart).GetSecondsTotal() / 60.0f / CGUIEPGGridContainerModel::MINSPERBLOCK; | ||
| newBlockIndex = std::ceil(fBlockIndex); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
ksooo
force-pushed
the
pvr-fix-jumping-epg-grid
branch
from
a0e18d4
to
3f15b54
Compare
|
@Jalle19 refactored. much better now, imo. |
Jalle19
approved these changes
Aug 23, 2017
|
jenkins errors are unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes jumping epg grid timeline while switching channel groups in Guide window. This has been reported for both Krypton and Leia several times. :-/ Finally I was able to reproduce this and thus a fix was possible.
This has been runtime tested on macOS, latest Kodi master (as usual on my end).
@Jalle19 mind taking a look.