Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PVR] Change context menu items for 'in progress' recordings. #12763

Merged
merged 1 commit into from
Sep 2, 2017

Conversation

ksooo
Copy link
Member

@ksooo ksooo commented Sep 2, 2017

For 'in progress' recordings:

  • Remove from context menu
    ++ "Delete"
    ++ "Rename"
    ++ "Edit"

  • Add to context menu
    ++ "Stop recording"

@da-anda fyi

@xhaggi mind doing the review?

@ksooo ksooo added Type: Improvement non-breaking change which improves existing functionality Component: PVR v18 Leia labels Sep 2, 2017
@ksooo ksooo added this to the L 18.0-alpha1 milestone Sep 2, 2017
@ksooo ksooo requested a review from xhaggi September 2, 2017 14:38
@ksooo ksooo force-pushed the pvr-inprogress-recordings-ctx-menu branch from 26de2e2 to 89393ba Compare September 2, 2017 14:42
Copy link
Member

@xhaggi xhaggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, looking good.

@da-anda
Copy link
Member

da-anda commented Sep 2, 2017

thanks

@ksooo
Copy link
Member Author

ksooo commented Sep 2, 2017

jenkins error is unrelated

@ksooo ksooo merged commit 3a7e833 into xbmc:master Sep 2, 2017
@ksooo ksooo deleted the pvr-inprogress-recordings-ctx-menu branch September 2, 2017 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: PVR Type: Improvement non-breaking change which improves existing functionality v18 Leia
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants