Partial revert of imdb crashfix due to a introduced bug #12767
Conversation
one part of the fix for the crashed on imdb caused an issue that it is no longer possible to manually add content to the videolibrary. Removing one of the checks for a non existing VideoInfoTag is getting rid of that bug.
lobermann
force-pushed
the
imdb_scrape_crash
branch
from
c87949e
to
f67cec9
Compare
|
Probably I'm able to confirm the fix later in the evening. I will test it for sure, not later than tomorrow. |
|
I tested it just now and manually adding files works at least for movies, which doesn't worked before. So at least that is fixed. I assume that everything else will work, too. I can do further tests tomorrow if needed. Just ping me in case. |
|
One negative report: https://forum.kodi.tv/showthread.php?tid=298461&pid=2643031#pid2643031 |
|
Probably not related because the user misses to mention that's the artwork which is missing. The scraping itself seems to work fine See: https://forum.kodi.tv/showthread.php?tid=298461&pid=2643266#pid2643266 |
|
Please elaborate how this fixes your issue. I don't get why the check for empty Videoinfotag caused a problem as an empty tag triggered a crash here previously, right? |
|
Because the tag is almost guaranteed to be empty, here, and the The actual crash fix is, I assume, fixed by the other half of the reverted commit, which stays |
|
jenkins build this please |
|
@koying: Ah yes, now I see. Thanks for explaining it. +1 in that case. |
|
Was this issue already fixed in Krypton branch? |
|
The regression was introduced in 18. PS: original PR: #12373 |
|
jenkins build and merge |
|
The regression is in 17.4 version too. |
|
Ah, right. The regression was backported to 17.4 |
|
@lobermann care to create a fix for krypton? |
|
afaik he is on vacation so I made the PR: I did just checkout the Krypton branch and cherry-picked, I didn't even compile! |
As discussed with @DaVukovic and @koying in slack this reverts part of my previous imdb crash fix as it was causing a bug in that content can no longer be added manually to the videolibrary.
I would appreciate if also somebody else can also try this PR, so that we are really sure it fixes the issue :-)