Split YUV2RGB shader into GL/GLES #12794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrusak
added
v18 Leia
Type: Cleanup
FernetMenta
approved these changes
Sep 13, 2017
Rechi
reviewed
Sep 13, 2017
| void SetContrast(float contrast) override { m_contrast = contrast; } | ||
| void SetNonLinStretch(float stretch) override { m_stretch = stretch; } | ||
|
|
||
| virtual GLint GetVertexLoc() { return m_hVertex; } |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| void SetNonLinStretch(float stretch) override { m_stretch = stretch; } | ||
|
|
||
| virtual GLint GetVertexLoc() { return m_hVertex; } | ||
| virtual GLint GetYcoordLoc() { return m_hYcoord; } |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
|
||
| virtual GLint GetVertexLoc() { return m_hVertex; } | ||
| virtual GLint GetYcoordLoc() { return m_hYcoord; } | ||
| virtual GLint GetUcoordLoc() { return m_hUcoord; } |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| virtual GLint GetVertexLoc() { return m_hVertex; } | ||
| virtual GLint GetYcoordLoc() { return m_hYcoord; } | ||
| virtual GLint GetUcoordLoc() { return m_hUcoord; } | ||
| virtual GLint GetVcoordLoc() { return m_hVcoord; } |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| virtual GLint GetUcoordLoc() { return m_hUcoord; } | ||
| virtual GLint GetVcoordLoc() { return m_hVcoord; } | ||
|
|
||
| virtual void SetMatrices(GLfloat *p, GLfloat *m) { m_proj = p; m_model = m; } |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| virtual GLint GetVcoordLoc() { return m_hVcoord; } | ||
|
|
||
| virtual void SetMatrices(GLfloat *p, GLfloat *m) { m_proj = p; m_model = m; } | ||
| virtual void SetAlpha(GLfloat alpha) { m_alpha = alpha; } |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
afedchin
approved these changes
Sep 14, 2017
lrusak
force-pushed
the
split-yuv2rgb-shader
branch
from
d018a94
to
dcd1f69
Compare
|
jenkins build and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on GL and GLES this works the same way as before.
This cleans up much of the ifdefs in the code.
Should be tested on windows as this affects it and I don't build for windows.