Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[music] SortByTrackNumber as default sort for "songs" #12834

Merged
merged 1 commit into from
Sep 25, 2017

Conversation

DaveTBlake
Copy link
Member

The most natural default sort order for viewing songs is track number. But on a clean installation "songs" nodes are currently sorted by file name, and this catches a number of users out. Many get very confused because the name my include a track number, so the odd sorting only shows up when they come to a multiple disc album e.g. have two track 01s next to each other.

A trivial change @jjd-uk requested, and makes sense to me.

@DaveTBlake DaveTBlake added Type: Improvement non-breaking change which improves existing functionality Component: Music v18 Leia labels Sep 24, 2017
@DaveTBlake DaveTBlake added this to the L 18.0-alpha1 milestone Sep 24, 2017
@razzeee
Copy link
Member

razzeee commented Sep 24, 2017

Just one question, the label for each row is still how you want it in this case?

Copy link
Member

@jjd-uk jjd-uk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to operate as I'd expect sorting by track where there is one then falling back to name sorting where there isn't.

So +1 from me.

@DaveTBlake
Copy link
Member Author

DaveTBlake commented Sep 25, 2017

Just one question, the label for each row is still how you want it in this case?

Yes @razzeee I think so

@razzeee
Copy link
Member

razzeee commented Sep 25, 2017

jenkins build and merge

@jenkins4kodi jenkins4kodi merged commit 363a7c8 into xbmc:master Sep 25, 2017
@DaveTBlake DaveTBlake deleted the SongSortDefault branch March 1, 2019 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Music Type: Improvement non-breaking change which improves existing functionality v18 Leia
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants