Controller dialog: Resize layouts #12884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good to me |
|
Jenkins not needed. I plan to merge in a few hours. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the controller dialog uses 16:9 images. This doesn't work well for controllers that are held vertically, such as the Atari 5600. As a result, the controllers would appear really tiny. This PR changes the controller dialog to use square layouts to better allow for vertical controllers.
All controller add-ons have been updated. The update add-ons have been submitted in xbmc/repo-resources#33, which should be merged with this PR.
Motivation and Context
Upcoming player window will use square layouts, and I realized how much better that sounds than rectangles with an arbitrary (and varying) aspect ratio.
How Has This Been Tested?
Tested in controller dialog and add-on browser.
Screenshots (if appropriate):
Before:
After:
Types of change