Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controller dialog: Resize layouts #12884

Merged
merged 2 commits into from Oct 6, 2017

Conversation

@garbear
Copy link
Member

commented Oct 5, 2017

Currently, the controller dialog uses 16:9 images. This doesn't work well for controllers that are held vertically, such as the Atari 5600. As a result, the controllers would appear really tiny. This PR changes the controller dialog to use square layouts to better allow for vertical controllers.

All controller add-ons have been updated. The update add-ons have been submitted in xbmc/repo-resources#33, which should be merged with this PR.

Motivation and Context

Upcoming player window will use square layouts, and I realized how much better that sounds than rectangles with an arbitrary (and varying) aspect ratio.

How Has This Been Tested?

Tested in controller dialog and add-on browser.

Screenshots (if appropriate):

Before:

screenshot001

After:

screenshot000

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
@ronie

This comment has been minimized.

Copy link
Member

commented Oct 5, 2017

looks good to me

@garbear

This comment has been minimized.

Copy link
Member Author

commented Oct 6, 2017

Jenkins not needed. I plan to merge in a few hours.

@garbear garbear merged commit 8988343 into xbmc:master Oct 6, 2017

@garbear garbear deleted the garbear:controller-resize branch Oct 6, 2017

@Rechi Rechi added this to the L 18.0-alpha1 milestone Oct 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.