Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[depends] bump m4 to 1.4.18 & fix crash for OSX 10.13 #12896

Merged
merged 2 commits into from Oct 9, 2017
Merged

[depends] bump m4 to 1.4.18 & fix crash for OSX 10.13 #12896

merged 2 commits into from Oct 9, 2017

Conversation

Rechi
Copy link
Member

@Rechi Rechi commented Oct 8, 2017

Description

Bump m4 to version 1.4.18 and a patch to fix an instant crash on OSX 10.13.

Motivation and Context

On OSX 10.13 (High Sierra) m4 is crashing with Illegal instruction: 4

How Has This Been Tested?

Tested by @ksooo, executing m4 now works.

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the Code guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have added tests to cover my change
  • All new and existing tests passed

@Rechi Rechi added this to the L 18.0-alpha1 milestone Oct 8, 2017
ksooo
ksooo approved these changes Oct 8, 2017
View reviewed changes
Copy link
Member

@ksooo ksooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suffered from the crash, runtime tested the fix and confirm it working.

@Rechi Rechi merged commit 333fe79 into xbmc:master Oct 9, 2017
@Rechi Rechi deleted the dependsFixOsxM4 branch October 9, 2017 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksooo ksooo ksooo approved these changes

Assignees
No one assigned
Labels
Component: Depends v18 Leia
Projects
None yet
Milestone
Leia 18.0-alpha1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Rechi @ksooo