Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cmake] refactor addon bindings #12922

Merged
merged 2 commits into from Oct 17, 2017
Merged

Conversation

wsnipex
Copy link
Member

@wsnipex wsnipex commented Oct 13, 2017

refactor definition, install, copying of addon bindings/headers

  • old addon-bindings.mk was a relic from autotools
  • move to cmake syntax
  • unify definition of addon bindings/headers in a single file
  • remove duplication in install script
  • allow including whole directories

Description

Motivation and Context

Cleanup and new functionality

How Has This Been Tested?

only on linux - and not thoroughly

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

ping @AlwinEsch @hudokkow @Rechi @FernetMenta

@wsnipex wsnipex added Component: Binary add-ons Type: Cleanup non-breaking change which removes non-working or unmaintained functionality CMake Type: Improvement non-breaking change which improves existing functionality v18 Leia labels Oct 13, 2017
@wsnipex
Copy link
Member Author

wsnipex commented Oct 13, 2017

jenkins build this with addons please

@wsnipex
Copy link
Member Author

wsnipex commented Oct 13, 2017

jenkins build this with addons please

@FernetMenta
Copy link
Contributor

thanks!

@wsnipex
Copy link
Member Author

wsnipex commented Oct 14, 2017

updated: also move kodi-addon-dev-kit handling to AddonBindings.cmake

jenkins build this with addons please

@wsnipex wsnipex merged commit 95762bd into xbmc:master Oct 17, 2017
@wsnipex wsnipex deleted the addon-binding-rework branch October 17, 2017 11:28
@Rechi Rechi added this to the L 18.0-alpha1 milestone Oct 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake Component: Binary add-ons Type: Cleanup non-breaking change which removes non-working or unmaintained functionality Type: Improvement non-breaking change which improves existing functionality v18 Leia
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants