Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peripherals: Fix list not refreshing in peripherals dialog #12960

Merged
merged 4 commits into from
Nov 11, 2017

Conversation

garbear
Copy link
Member

@garbear garbear commented Oct 25, 2017

Currently, the list of peripherals shown from Settings -> System -> Input -> Peripherals is static and does not update when a device is plugged/unplugged. This PR fixes that.

Motivation and Context

Users expect peripherals to show up when plugged in.

How Has This Been Tested?

Tested on OSX with various controllers.

Screenshots (if appropriate):

peripherals dialog

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@garbear garbear added Type: Fix non-breaking change which fixes an issue Component: Input v18 Leia labels Oct 25, 2017
@garbear garbear added this to the L 18.0-alpha1 milestone Oct 25, 2017
@Rechi
Copy link
Member

Rechi commented Nov 2, 2017

wrong revision was build
jenkins build this please

@garbear
Copy link
Member Author

garbear commented Nov 3, 2017

Currently, the Cancel button is always focused on dialog open. I'll try to change to focus the peripherals list instead.

@garbear
Copy link
Member Author

garbear commented Nov 10, 2017

K, peripherals list is now focused on dialog open. jenkins build this please

@garbear
Copy link
Member Author

garbear commented Nov 11, 2017

WIN-UWP-ARM failures are unrelated

@garbear garbear merged commit 32cc2b3 into xbmc:master Nov 11, 2017
@garbear garbear deleted the peripherals-dialog branch November 11, 2017 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Input Type: Fix non-breaking change which fixes an issue v18 Leia
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants