FIX: Only remove options for actual URL in URIUtils::Split (fixes #17627)

[koying]

@mkortstiege @razzeee

Quick fix for the issue we discussed about.
Untested, so if you could make it tested, somehow...

[Rechi]

TestURIUtils.Split fails on all platforms

[mkortstiege]

Actual change looks good to me.

[razzeee]

@koying can you try razzeee@9403799

[koying]

@Rechi

xbmc/xbmc/utils/test/TestURIUtils.cpp

Line 127 in 8ddffac

URIUtils::Split("/path/to/movie.avi?showinfo=true", varpathOptional, varfileOptional);

The test case is basically what this PR is trying to "solve".
AFAIK, plain filenames are not URI, so something like "/path/to/movie.avi?showinfo=true" is actually invalid.

I'd remove the testcase, or replace by "file:///path/to/movie.avi?showinfo=true", but your thoughts are welcome

[koying]

Added an additional testcase for the specific one we're trying to solve

[koying]

jenkins build this please

[koying]

@Rechi Test cases ok. Good for you?

test suite working again

[Rechi]

wrong revision was build
jenkins build this please

[MartijnKaijser]

@koying you want this backported or risk too high?

[koying]

Actually, the code introducing the issue is not in K, so irrelevant