Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GUI] fix content dialog when changing content type back to "None" #12965

Merged
merged 1 commit into from
Oct 28, 2017
Merged

[GUI] fix content dialog when changing content type back to "None" #12965

merged 1 commit into from
Oct 28, 2017

Conversation

phil65
Copy link
Contributor

@phil65 phil65 commented Oct 27, 2017 •
edited
Loading

Description

Changing content type back to "None" is not possible. This fixes it.

How Has This Been Tested?

By setting content type to some media type and then trying to change it back to "None"

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the Code guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have added tests to cover my change
  • All new and existing tests passed

@razzeee
Copy link
Member

razzeee commented Oct 28, 2017

Thanks, tested this on windows also.

@razzeee
Copy link
Member

razzeee commented Oct 28, 2017

jenkins build and merge

@MartijnKaijser MartijnKaijser added this to the L 18.0-alpha1 milestone Oct 28, 2017
@MartijnKaijser MartijnKaijser added Type: Fix non-breaking change which fixes an issue v18 Leia labels Oct 28, 2017
@phil65
Copy link
Contributor Author

phil65 commented Oct 28, 2017

jenkins build and merge

@jenkins4kodi jenkins4kodi merged commit 910143c into xbmc:master Oct 28, 2017
@phil65 phil65 deleted the content_dialog branch October 29, 2017 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Type: Fix non-breaking change which fixes an issue v18 Leia
Projects
None yet
Milestone
Leia 18.0-alpha1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@phil65 @razzeee @MartijnKaijser @jenkins4kodi